Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devtool link is broken #4736

Closed
shelldandy opened this issue Jul 4, 2018 · 4 comments
Closed

Devtool link is broken #4736

shelldandy opened this issue Jul 4, 2018 · 4 comments

Comments

@shelldandy
Copy link
Contributor

// See the discussion in https://github.com/facebook/create-react-app/issues/343.

Seems like the . needs a space after the url so it doesn't redirect to a 404 page 😛

@gaearon
Copy link
Contributor

gaearon commented Jul 4, 2018

I think it's assumed that the reader will copy the link without . at the end.
Happy to take a PR removing it though!

@shelldandy
Copy link
Contributor Author

But a lot of users (myself included) like to read the sourcecode directly from github to get inspiration or see how you guys reason about things

@shelldandy
Copy link
Contributor Author

Here you go @gaearon

#4741

@Timer
Copy link
Contributor

Timer commented Jul 5, 2018

Thanks!

@Timer Timer closed this as completed Jul 5, 2018
@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants