From a058d285231fab1bbd524af41a2ab5fd658cbcfe Mon Sep 17 00:00:00 2001 From: Ian Sutherland Date: Thu, 25 Jul 2019 10:51:14 -0600 Subject: [PATCH 1/2] Update deploy instructions in contributing guide --- CONTRIBUTING.md | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 76e704dacb1..5e7275abc6c 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -135,8 +135,8 @@ By default git would use `CRLF` line endings which would cause the scripts to fa ## Cutting a Release -1. Tag all merged pull requests that go into the release with the relevant milestone. Each merged PR should also be labeled with one of the [labels](https://github.com/facebook/create-react-app/labels) named `tag: ...` to indicate what kind of change it is. -2. Close the milestone. +1. Tag all merged pull requests that go into the release with the relevant milestone. Each merged PR should also be labeled with one of the [labels](https://github.com/facebook/create-react-app/labels) named `tag: ...` to indicate what kind of change it is. **Make sure all breaking changes are correctly labelled with `tag: breaking change`.** +2. Close the milestone and create a new one for the next release. 3. In most releases, only `react-scripts` needs to be released. If you don’t have any changes to the `packages/create-react-app` folder, you don’t need to bump its version or publish it (the publish script will publish only changed packages). 4. Note that files in `packages/create-react-app` should be modified with extreme caution. Since it’s a global CLI, any version of `create-react-app` (global CLI) including very old ones should work with the latest version of `react-scripts`. 5. Run `yarn compile:lockfile`. The command will generate an updated lockfile in `packages/create-react-app` that should be committed. @@ -152,7 +152,13 @@ By default git would use `CRLF` line endings which would cause the scripts to fa 9. Wait for a long time, and it will get published. Don’t worry that it’s stuck. In the end the publish script will prompt for versions before publishing the packages. 10. After publishing, create a GitHub Release with the same text as the changelog entry. See previous Releases for inspiration. -Make sure to test the released version! If you want to be extra careful, you can publish a prerelease by running `npm run publish -- prepatch --canary --preid next --dist-tag next --npm-client npm --force-publish` instead of `npm run publish`. +Make sure to test the released version! If you want to be extra careful, you can publish a prerelease by running `npm run publish -- --canary=next --exact --cd-version --npm-tag=next` instead of `npm run publish`. + +## Releasing the Docs + +1. Go to the `docusaurus/website` directory +2. Run `yarn build` +3. Run `GIT_USER= CURRENT_BRANCH=master USE_SSH=true yarn run publish-gh-pages` --- From c2ff8087fbcc0ed98f9b0fe587a6ab0c5c2c3b2b Mon Sep 17 00:00:00 2001 From: Ian Sutherland Date: Thu, 25 Jul 2019 10:59:14 -0600 Subject: [PATCH 2/2] Update docs publishing instructions --- CONTRIBUTING.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 5e7275abc6c..95782952f67 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -158,7 +158,8 @@ Make sure to test the released version! If you want to be extra careful, you can 1. Go to the `docusaurus/website` directory 2. Run `yarn build` -3. Run `GIT_USER= CURRENT_BRANCH=master USE_SSH=true yarn run publish-gh-pages` +3. You'll need an [access token for the GitHub API](https://help.github.com/articles/creating-an-access-token-for-command-line-use/). Save it to this environment variable: `export GITHUB_AUTH="..."` +4. Run `GIT_USER= CURRENT_BRANCH=master USE_SSH=true yarn run publish-gh-pages` ---