From b4daac96c87f8c422208ce0ff0617c92207f86ee Mon Sep 17 00:00:00 2001 From: Endilie Yacop Sucipto Date: Thu, 18 Apr 2019 19:04:53 +0800 Subject: [PATCH] fix(v2): fix hot reload sometimes not working due to altered modules (#1370) --- packages/docusaurus/lib/client/exports/ComponentCreator.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/packages/docusaurus/lib/client/exports/ComponentCreator.js b/packages/docusaurus/lib/client/exports/ComponentCreator.js index 5efc1dfe8f9c..dd85605e5ccc 100644 --- a/packages/docusaurus/lib/client/exports/ComponentCreator.js +++ b/packages/docusaurus/lib/client/exports/ComponentCreator.js @@ -13,7 +13,6 @@ import registry from '@generated/registry'; function ComponentCreator(path) { const modules = routesAsyncModules[path]; - const originalModules = modules; const optsModules = []; const optsWebpack = []; const mappedModules = {}; @@ -63,8 +62,8 @@ function ComponentCreator(path) { modules: optsModules, webpack: () => optsWebpack, render: (loaded, props) => { - // Transform back loaded modules back into the original structure. - const loadedModules = originalModules; + // clone the original object since we don't want to alter the original. + const loadedModules = JSON.parse(JSON.stringify(modules)); Object.keys(loaded).forEach(key => { let val = loadedModules; const keyPath = key.split('.');