Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redux docs next page link not working #1344

Closed
yangshun opened this issue Apr 8, 2019 · 9 comments · Fixed by #1488
Closed

Redux docs next page link not working #1344

yangshun opened this issue Apr 8, 2019 · 9 comments · Fixed by #1488
Labels
bug An error in the Docusaurus core causing instability or issues with its execution good first issue If you are just getting started with Docusaurus, this issue should be a good place to begin. help wanted Asking for outside help and/or contributions to this particular issue or PR.

Comments

@yangshun
Copy link
Contributor

yangshun commented Apr 8, 2019

🐛 Bug Report

Docusaurus generates a 404 link in Redux docs.

Have you read the Contributing Guidelines on issues?

Yes

To Reproduce

(Write your steps here:)

  1. Go to https://redux.js.org/faq
  2. Go to the bottom of the page and click on "General"

Expected behavior

Go to the General page.

(Write what you thought would happen.)

Actual Behavior

404

Reproducible Demo

Go to https://redux.js.org/faq

I think the problem is because the FAQ page has an ambiguous ID that is also a dir within docs. If I change the FAQ.md id to faq-index it'll be fine, but the URL will be ugly. Perhaps we should support a field to allow overriding of the URL, instead of just using the front matter id.

@yangshun yangshun added bug An error in the Docusaurus core causing instability or issues with its execution good first issue If you are just getting started with Docusaurus, this issue should be a good place to begin. help wanted Asking for outside help and/or contributions to this particular issue or PR. labels Apr 8, 2019
@alzaar
Copy link

alzaar commented Apr 9, 2019

Hey I am new to contributing on github. Can I take this issue ? Or is it taken?

@yangshun
Copy link
Contributor Author

yangshun commented Apr 9, 2019

@alzaar it's yours!

I've added an "issue: claimed" label so that others will know not to start work on the issue. If you change your mind about the issue, no worries! Just let me know so that I can remove the label and free it up for someone else to claim.

I'll check in with you periodically so that we can keep the task updated with the progress.

@yangshun yangshun added the status: claimed Issue has been claimed by a contributor who plans to work on it. label Apr 9, 2019
@alzaar
Copy link

alzaar commented Apr 9, 2019

Thanks! Could explain a bit more about the issue? I cloned the repo and am messing around with the code to see how it works.

@yangshun
Copy link
Contributor Author

yangshun commented Apr 9, 2019

Hi @alzaar, I didn't do too much investigation into the bug, but I wrote down what I think could be the cause at the bottom of the issue. Did you manage to reproduce the bug?

@alzaar
Copy link

alzaar commented Apr 10, 2019

I am going to work on it and see if I can find the bug. But I will keep you posted!

@joybh98
Copy link

joybh98 commented May 2, 2019

@alzaar are you working on this? If not I'll be happy to work on it.

@alzaar
Copy link

alzaar commented May 2, 2019

Hey @joybhallaa! Yes I am. I will let you know in case I am not able so you can work on it.

@joybh98
Copy link

joybh98 commented May 2, 2019

@alzaar, okay! No problem!

@endiliey
Copy link
Contributor

@alzaar, Still working on it ?

I'll free it up now for anyone else who wanted to work on it. Let me know if you are still working on it

@endiliey endiliey removed the status: claimed Issue has been claimed by a contributor who plans to work on it. label May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error in the Docusaurus core causing instability or issues with its execution good first issue If you are just getting started with Docusaurus, this issue should be a good place to begin. help wanted Asking for outside help and/or contributions to this particular issue or PR.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants