Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLI]: 🔔Notify users if they're using an older version #2199

Closed
jamesgeorge007 opened this issue Jan 8, 2020 · 9 comments · Fixed by #3032
Closed

[CLI]: 🔔Notify users if they're using an older version #2199

jamesgeorge007 opened this issue Jan 8, 2020 · 9 comments · Fixed by #3032
Labels
difficulty: intermediate Issues that are medium difficulty level, e.g. moderate refactoring with a clear test plan. feature This is not a bug or issue with Docusausus, per se. It is a feature request for the future. help wanted Asking for outside help and/or contributions to this particular issue or PR. mlh Major League Hacking Fellowship

Comments

@jamesgeorge007
Copy link
Contributor

update-notifier serves the purpose here. As from the tagline, Inform users of your package of updates in a non-intrusive way.
@jamesgeorge007 jamesgeorge007 added feature This is not a bug or issue with Docusausus, per se. It is a feature request for the future. status: needs triage This issue has not been triaged by maintainers labels Jan 8, 2020
@yangshun yangshun added help wanted Asking for outside help and/or contributions to this particular issue or PR. and removed status: needs triage This issue has not been triaged by maintainers labels Jan 9, 2020
@strtw
Copy link

strtw commented Feb 10, 2020

Hi @yangshun I've been working on this in my fork and have had some success getting the notification to display in testing for v 1.x. when I hard code the old version per update-notifier's testing instructions. I'd be glad to be assigned the issue to implement this feature.

Screen Shot 2020-02-09 at 6 25 23 PM

@jamesgeorge007
Copy link
Contributor Author

@strtw are you still working on this?

@yangshun
Copy link
Contributor

This would be a really cool feature to add!

@strtw
Copy link

strtw commented Feb 26, 2020

@jamesgeorge007 Haven't since my last post but would be glad to be assigned and continue working on it

@lex111
Copy link
Contributor

lex111 commented Feb 29, 2020

@strtw go for it! Although before it would be nice to bring to completion of your previous PR #2282

@yangshun yangshun added the mlh Major League Hacking Fellowship label Jun 5, 2020
@yangshun
Copy link
Contributor

yangshun commented Jun 5, 2020

We'd love to have this feature! @strtw is this something you're still working on?

@yangshun yangshun added the difficulty: intermediate Issues that are medium difficulty level, e.g. moderate refactoring with a clear test plan. label Jun 5, 2020
@jamesgeorge007
Copy link
Contributor Author

jamesgeorge007 commented Jun 5, 2020 •
edited
Loading

@strtw if you're caught up, I can work on a PR.

@strtw
Copy link

strtw commented Jun 5, 2020

@jamesgeorge007 Yah of course! Here's a link to the draft PR I submitted in case it helps. #2890

@teikjun
Copy link
Contributor

teikjun commented Jul 7, 2020

I'll work on this for v2 :)

@teikjun teikjun mentioned this issue Jul 8, 2020
Merged
@slorber slorber mentioned this issue Jul 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: intermediate Issues that are medium difficulty level, e.g. moderate refactoring with a clear test plan. feature This is not a bug or issue with Docusausus, per se. It is a feature request for the future. help wanted Asking for outside help and/or contributions to this particular issue or PR. mlh Major League Hacking Fellowship
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(v2): notify users when docusaurus version is outdated MLH-Fellowship/docusaurus
5 participants
@yangshun @lex111 @strtw @jamesgeorge007 @teikjun