Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alpha-54: Site title no longer wraps - search box moves #2699

Closed
TomBrien opened this issue Apr 30, 2020 · 3 comments · Fixed by #2791
Closed

alpha-54: Site title no longer wraps - search box moves #2699

TomBrien opened this issue Apr 30, 2020 · 3 comments · Fixed by #2791
Labels
bug An error in the Docusaurus core causing instability or issues with its execution help wanted Asking for outside help and/or contributions to this particular issue or PR.

Comments

@TomBrien
Copy link
Contributor

🐛 Bug Report

In alpha-0.49 and previous (I believe but I'm struggling to get these to build now), longer site titles would wrap at the search in the header bar. This was especially important on mobile browsers where the width is obviously limited. As of alpha-54, the title is not wrapping and search box is being pushed out of the header.

Have you read the Contributing Guidelines on issues?

Yes

To Reproduce

  1. Install Docusaurus and set up with a multi-word site title (total length more than 12 characters or so)
  2. Enable the search plug in
  3. Visit site on a mobile browser

Expected behavior

Words should wrap to ensure proper placement of search box

Actual Behavior

Title is shown on one line and search is moved
iOS:
IMG_0993

Pixel 4 (on BrowserStack)
image

Your Environment

  • Docusaurus version used: alpha-54
  • Environment name and version: Chrome and Safari on iOS,
  • Operating system and version (desktop or mobile): iOS on iPhone XS. Using browser stack I see it on other devices, including android, depending on screen size/resolution
@TomBrien TomBrien added bug An error in the Docusaurus core causing instability or issues with its execution status: needs triage This issue has not been triaged by maintainers labels Apr 30, 2020
@yangshun
Copy link
Contributor

yangshun commented Apr 30, 2020

There's no good way around this as the site title can be potentially very long. I think as a lasting solution we could make the search as an icon-only on mobile, and focusing on it will expand and fill the whole bar, and the title disappears.

@yangshun yangshun added help wanted Asking for outside help and/or contributions to this particular issue or PR. and removed status: needs triage This issue has not been triaged by maintainers labels Apr 30, 2020
@TomBrien
Copy link
Contributor Author

An icon that expands (on top of title) when tapped would be a really nice solution. Or on mobile move the search into the hamburger menu

@marcosvega91
Copy link
Contributor

marcosvega91 commented Apr 30, 2020

Hi, the only thing to do is to change the media query of the search-bar class.
Now the icon is shown under 360px. I think that we need to change it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error in the Docusaurus core causing instability or issues with its execution help wanted Asking for outside help and/or contributions to this particular issue or PR.
Projects
None yet
3 participants