Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infima] Breadcrums not visible on dark theme #2918

Closed
RDIL opened this issue Jun 11, 2020 · 4 comments · Fixed by facebookincubator/infima#48
Closed

[Infima] Breadcrums not visible on dark theme #2918

RDIL opened this issue Jun 11, 2020 · 4 comments · Fixed by facebookincubator/infima#48
Labels
bug An error in the Docusaurus core causing instability or issues with its execution

Comments

@RDIL
Copy link
Contributor

RDIL commented Jun 11, 2020

🐛 Bug Report

Pretty easy bug to fix,

light theme (proper behavior):
Screenshot 2020-06-10 at 10 04 25 PM

dark theme (barely visible due to black color):
Screenshot 2020-06-10 at 10 04 54 PM

NOTE: I would open this issue in the infima repo but it seems all the links to it are dead??

@RDIL RDIL added bug An error in the Docusaurus core causing instability or issues with its execution status: needs triage This issue has not been triaged by maintainers labels Jun 11, 2020
@yangshun
Copy link
Contributor

The links are not dead, just not public. Thanks for reporting, we didn't prioritize it since breadcrumbs aren't used on Docusaurus at the moment.

@yangshun yangshun removed the status: needs triage This issue has not been triaged by maintainers label Jun 11, 2020
@RDIL
Copy link
Contributor Author

RDIL commented Jun 11, 2020

@yangshun what do you mean not public? Why not?

By definition, the links are dead if they aren't public.

@yangshun
Copy link
Contributor

By definition, the links are dead if they aren't public.

Sure

What do you mean not public? Why not?

I haven't made it ready for very broad open source consumption. It still needs to go through a round of internal reviews.

@RDIL
Copy link
Contributor Author

RDIL commented Jun 11, 2020

Okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error in the Docusaurus core causing instability or issues with its execution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants