Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PWA Lighthouse start_url issues #4108

Closed
slorber opened this issue Jan 27, 2021 · 1 comment
Closed

PWA Lighthouse start_url issues #4108

slorber opened this issue Jan 27, 2021 · 1 comment
Labels
bug An error in the Docusaurus core causing instability or issues with its execution

Comments

@slorber
Copy link
Collaborator

slorber commented Jan 27, 2021

The Lighthouse PWA audit report some errors on Docusaurus v2 site itself, that we should figure out how to fix.

image

This may be because the PWA offline support is only enabled with an "activation strategy": https://v2.docusaurus.io/docs/next/api/plugins/@docusaurus/plugin-pwa/#offlinemodeactivationstrategies

So by default, the site homepage does not really have any offline support?
@slorber slorber added the bug An error in the Docusaurus core causing instability or issues with its execution label Jan 27, 2021
@slorber slorber changed the title PWA Lighthouse issues PWA Lighthouse start_url issues Jan 27, 2021
@Josh-Cena
Copy link
Collaborator

Should be fixed already by #4377🤔 The only issue Lighthouse reports right now is the icon not being maskable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug An error in the Docusaurus core causing instability or issues with its execution
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@slorber @Josh-Cena