Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the ability to provide a custom layout #737

Closed
JoelMarcey opened this issue Jun 7, 2018 · 5 comments
Closed

Document the ability to provide a custom layout #737

JoelMarcey opened this issue Jun 7, 2018 · 5 comments
Labels
documentation The issue is related to the documentation of Docusaurus good first issue If you are just getting started with Docusaurus, this issue should be a good place to begin.

Comments

@JoelMarcey
Copy link
Contributor

Is this a bug report?

No. See #128 for implementation details.

Have you read the Contributing Guidelines on issues?

Yes

Environment

N/A

Steps to Reproduce

See #128

Expected Behavior

N/A

Actual Behavior

N/A

Reproducible Demo

N/A
@JoelMarcey JoelMarcey added good first issue If you are just getting started with Docusaurus, this issue should be a good place to begin. documentation The issue is related to the documentation of Docusaurus labels Jun 7, 2018
@sunnylqm sunnylqm mentioned this issue Jun 12, 2018
Closed
@FarooqAR
Copy link

Can I take this issue?

@JoelMarcey JoelMarcey added the status: claimed Issue has been claimed by a contributor who plans to work on it. label Jun 14, 2018
@JoelMarcey
Copy link
Contributor Author

@FarooqAR Absolutely. Thank you very much! When you send the PR, we will review.

@FarooqAR
Copy link

@JoelMarcey Hasn't pr#763 already solved this issue?

@JoelMarcey
Copy link
Contributor Author

Ah -- I didn't even see that PR. Sorry. I guess it has been taken.

If you have feedback on the PR, please let us know in the PR itself.

@endiliey endiliey added v2-mvp and removed status: claimed Issue has been claimed by a contributor who plans to work on it. labels Aug 28, 2018
@endiliey
Copy link
Contributor

Custom layout got removed because upon investigation it actually doesn't work 😭

Let's leave custom layout on v2 implementation

@ebeneliason ebeneliason mentioned this issue Dec 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation The issue is related to the documentation of Docusaurus good first issue If you are just getting started with Docusaurus, this issue should be a good place to begin.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JoelMarcey @FarooqAR @endiliey