fix TestScheduler dispatch upon exec error #13203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change autoRun setting to avoid the long startup full-test run.
|
Hi, I checked in a non-code related to change so I can also see if the earlier test check failure is just a hiccup. Sure enough, the previously failed check has passed. However, a new check failed, but it is not related to the code change in this PR. So I think the code is ready for review, @SimenB please feel free to take a look when you have the cycle. Thanks. |
connectdotz
changed the title
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Modified
TestScheduler.scheduleTeststo capture runtime execError in aggregatedResults and notify reporters viaonRunComplete.fix #13187
Test plan
new tests have been added, all tests should pass.