Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete redundant branch in ReactElement and HTMLElement plugins #3731

Merged
merged 1 commit into from
Jun 4, 2017

Conversation

pedrottimark
Copy link
Contributor

Summary

The changes because of excellent Flow strict_call_arity in #3568 make it clear that if else if else statements can become if else in two plugins of pretty-format package.

Test plan

Jest

@codecov-io
Copy link

Codecov Report

Merging #3731 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3731      +/-   ##
==========================================
+ Coverage   62.64%   62.65%   +<.01%     
==========================================
  Files         183      183              
  Lines        6709     6705       -4     
  Branches        6        6              
==========================================
- Hits         4203     4201       -2     
+ Misses       2503     2501       -2     
  Partials        3        3
Impacted Files Coverage Δ
packages/pretty-format/src/plugins/HTMLElement.js 94.28% <100%> (+5.09%) ⬆️
packages/pretty-format/src/plugins/ReactElement.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fa0faf...d1cb3a6. Read the comment docs.

Copy link
Collaborator

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Man, I've seen this message and I was really hoping Flow started to do something on dead code elimination 😄. Good catch!

@cpojer cpojer merged commit 2e0c1bf into jestjs:master Jun 4, 2017
@cpojer
Copy link
Member

cpojer commented Jun 4, 2017

Thank you!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants