-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
include error message for preset json #4766
include error message for preset json #4766
Conversation
@@ -64,6 +64,11 @@ const setupPreset = ( | |||
// $FlowFixMe | |||
preset = (require(presetModule): InitialOptions); | |||
} catch (error) { | |||
if (error instanceof SyntaxError) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather flip it.
if (error.code === 'MODULE_NOT_FOUND') {
throw createConfigError(` Preset ${chalk.bold(presetPath)} not found.`);
}
throw createConfigError(
` Unable to load preset ${chalk.bold(presetPath)}:\n ${error.message}`,
);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SimenB I am getting a different error for that (AssertionError for the actual require), the error code will only be shown in test (MODULE_NOT_FOUND from jest-resolve).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, interesting. Thanks for checking!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a test.
Can you also update the changelog?
Nice! Thank you. |
Awesome! 💛 Thank you @xjlim! |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Fix #4755