Fix test retries that contain snapshots #8629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
reviewed
Jul 2, 2019
SimenB
reviewed
Jul 3, 2019
jeysal
reviewed
Jul 3, 2019
| event.test.errors = []; | ||
| // Clear any snapshot data that occurred in previous test run | ||
| global.expect.clearState(); |
There was a problem hiding this comment.
This forces expect to be available, while circus is so far not tightly coupled to it (and in theory built to be used anywhere, the legacy-code directory aside). Can we make it gracefully handle expect/clearState not being available and move it to a separate event handler?
There was a problem hiding this comment.
This is a great point, you are right we should find to prevent jest-circus of being coupled with expect.
SimenB
reviewed
Jul 4, 2019
| @@ -131,6 +132,8 @@ export const initialize = ({ | |||
| }); | |||
| setState({snapshotState, testPath}); | |||
|
|
|||
| addEventHandler(handleSnapshotStateAfterRetry(snapshotState)); | |||
SimenB
approved these changes
Jul 4, 2019
thymikee
approved these changes
Jul 4, 2019
This was referenced Oct 10, 2019
This was referenced Nov 1, 2019
This was referenced Dec 31, 2019
This was referenced Jan 7, 2020
This was referenced Jan 21, 2020
This was referenced Mar 21, 2020
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is heavily inspired by @palmerj3's PR #8019 and most of the credit goes to him
This should make snapshots play better with
retryTimes. I tried to add e2e tests for as much as I could. I don't know if I'm missing some use cases, would love some input on that.Fixes #7493
Closes #8015
Test plan
Added some e2e tests.