Formatting of annotations may change semantic meaning

[bethcutler]

Annotations are generally moved to the same line, but this may change the scope of the annotation.

Original code:

fun <T : Any?> testCasting(test: T, foo: String, bar: String): T {
  if (!foo.isEmpty()) {
    @Suppress("UNCHECKED_CAST")
    bar.isEmpty() || return (null as T)
  }
  return test
}

Formatted code:

fun <T : Any?> testCasting(test: T, foo: String, bar: String): T {
  if (!foo.isEmpty()) {
    @Suppress("UNCHECKED_CAST") bar.isEmpty() || return (null as T)
  }
  return test
}

After formatting, the Suppress annotation only applies on the first half of the expression, not the part of the expression where the cast actually occurs.

[cgrushko]

cc @strulovich

[strulovich]

I guess this is a problem in both ways, since converting case 2 into case 1 would also be a bug no? Does this mean we must preserve spacing on annotations? (At least for expressions)?

[davidtorosyan]

So be43fdb fixed #247, which I think is a duplicate of this, so closing this out as well. Please reopen if I'm wrong!