Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failed can't print error log when component's count more than 100 #420

Closed
1 task done
wangbax opened this issue Aug 21, 2018 · 6 comments
Closed
1 task done

Comments

@wangbax
Copy link

wangbax commented Aug 21, 2018

Version

    // Litho
    implementation 'com.facebook.litho:litho-core:0.17.0'
    implementation 'com.facebook.litho:litho-widget:0.17.0'
    compileOnly 'com.facebook.litho:litho-annotations:0.17.0'
    annotationProcessor 'com.facebook.litho:litho-processor:0.17.0'
    // SoLoader
    implementation 'com.facebook.soloader:soloader:0.3.0'
    // For integration with Fresco
    implementation('com.facebook.litho:litho-fresco:0.17.0') {
        exclude group: 'com.facebook.fresco'
    }
    // For testing
    testImplementation 'com.facebook.litho:litho-testing:0.17.0'
    // Sections
    implementation 'com.facebook.litho:litho-sections-core:0.17.0'
    implementation 'com.facebook.litho:litho-sections-widget:0.17.0'
    compileOnly 'com.facebook.litho:litho-sections-annotations:0.17.0'
    annotationProcessor 'com.facebook.litho:litho-sections-processor:0.17.0'

Issues and Steps to Reproduce

image

image

Expected Behavior

Build failed can print error log anytime.

Link to Code

@pavlospt
Copy link
Contributor

@wt1098078873 what do you mean by "component's count" ?

@passy
Copy link
Member

passy commented Aug 21, 2018

I don't understand the issue either, but I would not be surprised if this is related to unicode issues. We haven't been very careful in our String treatment in various places in the annotation processor.

@wangbax
Copy link
Author

wangbax commented Aug 21, 2018

@passy "component's count" meas "The number of component in my project". Can't print litho's error message when the number exceeds 100.

@passy
Copy link
Member

passy commented Aug 21, 2018

But the compiler error looks pretty legitimate to me regarding "param must be annotated with ...". There's definitely no limit for the number of components anywhere.

@pavlospt
Copy link
Contributor

@wt1098078873 There is a chance that you capped the javac error output. check this issue and give a try on the proposed solutions google/dagger#306

@wangbax
Copy link
Author

wangbax commented Aug 21, 2018

@pavlospt It work for me. thanks. 👍

@wangbax wangbax closed this as completed Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants