Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Argon2 Example for 2.0.0 #281

Closed
zer0x64 opened this issue Jul 19, 2022 · 2 comments
Closed

Argon2 Example for 2.0.0 #281

zer0x64 opened this issue Jul 19, 2022 · 2 comments

Comments

@zer0x64
Copy link
Contributor

zer0x64 commented Jul 19, 2022

Hey!

I recently tried to use the library with Argon2 as the client-side KDF, as recommended, using the 2.0.0 pre-release version. Since there were no examples and because there were lifetime issues(that I fixed using PhantomData), it took a while before finding out how to make it work. I believe adding an example on how to use it and set the parameters might be useful to others.

Since I recently did the work, I'll be willing on writing the example and open a PR for it, however I'm opening this issue beforehand to make sure that's something you'd want :)
@daxpedda
Copy link
Contributor

I believe we should update the simple_login example to just use Argon2 instead of Identity. Another separate example for custom KDF parameters would be great too!

@zer0x64 zer0x64 mentioned this issue Jul 20, 2022
Merged
@zer0x64
Copy link
Contributor Author

zer0x64 commented Jul 25, 2022

Done in #282

@zer0x64 zer0x64 closed this as completed Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@daxpedda @zer0x64