This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 421
Handle Possible Throw When Branching on Abstract Value #976
Labels
Comments
At the very least, the resulting error code should get some help text: |
PP0001 is currently used for errors that are generated the old way, via reportIntrospectionError. These errors should instead be generated by calling handleError directly, with specific error codes and relevant source locations. |
I can change the error handling. |
jwli229
added a commit
that referenced
this issue
Sep 26, 2017
Issue: #976 Summary: Use handleError with a helpful message instead of reportIntrospectionError Test Plan: Use a test case to trigger the error and saw the error message.
jwli229
added a commit
that referenced
this issue
Sep 26, 2017
Issue: #976 Summary: Use handleError with a helpful message instead of reportIntrospectionError Test Plan: Use a test case to trigger the error and saw the error message.
This was referenced Oct 31, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
On a branch based on an abstract value where one of the branches throws and the other doesn't (example above), a fatal error occurs since the result of the evaluation is a PossiblyNormalCompletion.
Prepack should handle the join of the branches in this case.
The text was updated successfully, but these errors were encountered: