From 03b9f041dbe846f7e6c5d9b91a8627053fde0853 Mon Sep 17 00:00:00 2001 From: Riccardo Cipolleschi Date: Tue, 17 Dec 2024 03:45:18 -0800 Subject: [PATCH] Improve E2E Stability for Android (#48286) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/48286 This change bumps the specs for the Android E2E tests. This has been reported to improve the stability of the tests. We need to keep part of the `flatlist.yml` commented as it creates an issue with Maestro as it takes too much memory. I'll reach out to the people working on Maestro to try and understand what's going on there. ## Changelog: [Internal] - Improve android Stability and reenable E2E tests on main Reviewed By: fabriziocucci Differential Revision: D67276601 fbshipit-source-id: 7cca253547063a0ec39da7de58806286c6632b07 --- .github/actions/maestro-android/action.yml | 4 +++- .github/workflows/test-all.yml | 4 +--- packages/rn-tester/.maestro/flatlist.yml | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/actions/maestro-android/action.yml b/.github/actions/maestro-android/action.yml index e3b535c22ff3c9..cd402beb36a39f 100644 --- a/.github/actions/maestro-android/action.yml +++ b/.github/actions/maestro-android/action.yml @@ -61,8 +61,10 @@ runs: with: api-level: 24 arch: x86 - ram-size: '4096M' + ram-size: '8192M' + heap-sizze: '4096M' disk-size: '10G' + cores: '4' disable-animations: false avd-name: e2e_emulator script: node .github/workflow-scripts/maestro-android.js ${{ inputs.app-path }} ${{ inputs.app-id }} ${{ inputs.maestro-flow }} ${{ inputs.flavor }} ${{ inputs.working-directory }} diff --git a/.github/workflows/test-all.yml b/.github/workflows/test-all.yml index 56801d297bd48f..ab899bbda05f65 100644 --- a/.github/workflows/test-all.yml +++ b/.github/workflows/test-all.yml @@ -436,9 +436,7 @@ jobs: run-e2e-tests: ${{ github.ref == 'refs/heads/main' || contains(github.ref, 'stable') || inputs.run-e2e-tests }} test_e2e_android_rntester: - # Temporarily disable RNTester tests on Android as they are quite flaky and they make CI always red - # if: ${{ github.ref == 'refs/heads/main' || contains(github.ref, 'stable') || inputs.run-e2e-tests }} - if: ${{ contains(github.ref, 'stable') || inputs.run-e2e-tests }} + if: ${{ github.ref == 'refs/heads/main' || contains(github.ref, 'stable') || inputs.run-e2e-tests }} runs-on: 4-core-ubuntu needs: [build_android] strategy: diff --git a/packages/rn-tester/.maestro/flatlist.yml b/packages/rn-tester/.maestro/flatlist.yml index 6db8d028cebf2b..17587f86a14533 100644 --- a/packages/rn-tester/.maestro/flatlist.yml +++ b/packages/rn-tester/.maestro/flatlist.yml @@ -11,8 +11,8 @@ appId: ${APP_ID} # iOS: com.meta.RNTester.localDevelopment | Android: com.facebo id: "Flatlist" - tapOn: id: "Basic" -# - assertVisible: -# id: "item_550" +- assertVisible: + id: "item_550" # - repeat: # while: # notVisible: