From e64e13fce394332ce609f0def35fa573f30138e9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?H=C3=A9ctor=20Ramos?= Date: Tue, 17 Jul 2018 20:59:53 -0700 Subject: [PATCH] Bump minimum Node version to 8.3 (#20236) Summary: Node rest/spread syntax started working without the harmony flag in 8.3 (https://github.com/facebook/react-native/pull/20178#issuecomment-404961149). Release Notes: [GENERAL] [BREAKING] [Node] - Bump minimum req. Node version to 8.3 Pull Request resolved: https://github.com/facebook/react-native/pull/20236 Differential Revision: D8876357 Pulled By: hramos fbshipit-source-id: 1f5f791ef318e70c6be8b23d887a1d650a68e594 --- local-cli/server/checkNodeVersion.js | 13 +++++-------- package.json | 2 +- 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/local-cli/server/checkNodeVersion.js b/local-cli/server/checkNodeVersion.js index 7eb55a6d87d715..cfc17dcf2d2293 100644 --- a/local-cli/server/checkNodeVersion.js +++ b/local-cli/server/checkNodeVersion.js @@ -14,7 +14,7 @@ var formatBanner = require('metro-core/src/formatBanner'); var semver = require('semver'); module.exports = function() { - if (!semver.satisfies(process.version, '>=8')) { + if (!semver.satisfies(process.version, '>=8.3')) { var engine = semver.satisfies(process.version, '<1') ? 'Node' : 'io.js'; var message = @@ -24,15 +24,12 @@ module.exports = function() { process.version + '.\n' + '\n' + - 'React Native runs on Node 8.0 or newer. There are several ways to ' + + 'React Native runs on Node 8.3 or newer. There are several ways to ' + 'upgrade Node.js depending on your preference.\n' + '\n' + - 'nvm: nvm install node && nvm alias default node\n' + - 'Homebrew: brew unlink iojs; brew install node\n' + - 'Installer: download the Mac .pkg from https://nodejs.org/\n' + - '\n' + - 'About Node.js: https://nodejs.org\n' + - 'Follow along at: https://github.com/facebook/react-native/issues/19226'; + 'nvm: nvm install 8.3 --reinstall-packages-from=node\n' + + 'Homebrew: brew update && brew upgrade node\n' + + 'Installer: download from https://nodejs.org/\n'; console.log( formatBanner(message, { chalkFunction: chalk.green, diff --git a/package.json b/package.json index 2ae553d549f3a3..eceeafd5139e12 100644 --- a/package.json +++ b/package.json @@ -8,7 +8,7 @@ "url": "git@github.com:facebook/react-native.git" }, "engines": { - "node": ">=8" + "node": ">=8.3" }, "prettier": { "requirePragma": true,