Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packager isn't detecting changes on node_modules #11549

Closed
rseemann opened this issue Dec 19, 2016 · 4 comments
Closed

Packager isn't detecting changes on node_modules #11549

rseemann opened this issue Dec 19, 2016 · 4 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@rseemann
Copy link

Description

Making changes on files on node_modules does not trigger a change in the bundler, therefore the new changes are not bundled into the app unless the packager is restarted.

Reproduction

Change a file at the node_modules folder and check that the bundler does not detect the file change (

onFileChange(type: string, filePath: string, stat: Stats) {
is never called). Older versions of react-native would detect this and mark the file as outdated.

Solution

Reenable the watching of node files or allow a way to customise this via config/env variables

Additional Information

  • React Native version: 0.39.2
  • Platform: iOS
  • Operating System: MacOS
@rseemann
Copy link
Author

Adding the package name here seems to fix the problem. Is there a way to pass this parameter via command line or env variable?

@santervo
Copy link

Same here. Installing new modules with npm install are not picked by app. I need to stop the packager and restart it completely.

@farwayer
Copy link
Contributor

duplicate #11301

@rseemann
Copy link
Author

rseemann commented Jan 2, 2017

Close in favor of #11301

@rseemann rseemann closed this as completed Jan 2, 2017
@facebook facebook locked as resolved and limited conversation to collaborators May 24, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

4 participants