Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrate #15185

Closed
sm2017 opened this issue Jul 25, 2017 · 1 comment
Closed

Upgrate #15185

sm2017 opened this issue Jul 25, 2017 · 1 comment
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@sm2017
Copy link
Contributor

sm2017 commented Jul 25, 2017

Please don't close issue immediately you reply

I open #15105 and #15153 before for this issue , I send PR #15046 and fix a websocket bug , In my local repository I don't know how can I use bug fixed version

react-native-git-upgrade doesn't support arbitrary commits. you should run it on the latest release before that commit, then update the version in package.json again to the commit you want. a PR to support this is welcome, if you don't want to work on that then please create a feature request on http://react-native.canny.io/

In this case , I have last released native codes version (With websocket bug) and specific commit of js codes

1- How can I upgrade both native and js codes to specific commit?
2- Can you release new version that includes 7e29b1f ?

@hramos
Copy link
Contributor

hramos commented Jul 25, 2017

Hey, thanks for opening the issue. I want to kindly direct you to the issue template that is displayed when you open a new issue. Specifically, there is a note there stating that issues that do not adhere to the template will be closed. We're dealing with a large number of open issues at the time and we kindly ask everyone to work with us and do a bit of work ahead of time in order to make sure issues are actionable. Thanks for your understanding.

It looks like your description is missing some necessary information, or the list of reproduction steps is not complete. Can you please add all the details specified in the template? This is necessary for people to be able to understand and reproduce the issue being reported.

I am going to close this, but feel free to open a new issue with the additional information provided. Thanks!

@hramos hramos closed this as completed Jul 25, 2017
@facebook facebook locked as resolved and limited conversation to collaborators Jul 25, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

3 participants