Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressable does not have onHoverIn/onHoverOut props, while Pressability does #32406

Closed
Saadnajmi opened this issue Oct 14, 2021 · 1 comment
Closed
Labels
Needs: Triage 🔍 p: Microsoft Partner: Microsoft Partner Resolution: Locked This issue was locked by the bot.

Comments

@Saadnajmi
Copy link
Contributor

Several desktop forks (react-native-macos, react-native-windows, react-native-web) support mouse events, and while the stock Pressable component has the ability to support mouse events, it seems we aren't forwarding some props properly from Pressable -> Pressability.

Pressability will calculate onMouseEnter / onMouseLeave event handlers based on the onHoverIn/onHoverOut callbacks passed into PressabilityConfig.

const mouseEventHandlers =

However, Pressable does not pass take in onHoverIn/onHoverOut props to pass to PressabilityConfig, so we can't take advantage of this functionality.
I made PR #32405 to address the issue. I created this bug meanwhile to track this issue

@Saadnajmi
Copy link
Contributor Author

Closed with #32405

@facebook facebook locked as resolved and limited conversation to collaborators Oct 27, 2022
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Oct 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Needs: Triage 🔍 p: Microsoft Partner: Microsoft Partner Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

3 participants