-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RCTConvert] NSString cannot be converted to NSNumber on v0.12.0 #3300
Comments
Are you setting the border color directly on a View or using another component? If the latter you may need to update it to call |
@ide yeah I was doing: this.refs.container.setNativeProps({'borderColor': '#dddddd'}); so I should change it to? import React from 'react-native';
import { processColor } from React;
this.refs.container.setNativeProps({'borderColor': processColor('#dddddd')}); in what other cases should I be using |
If that's necessary, I feel like setNativeProps or precomputeStyle (which is used by setNativeProps) should be updated to use processColor automatically. Can you let us know if that's required @yelled3? |
Facing the same problem.
|
use processColor works on me |
Sorry, I just saw |
yes it is :-)
agreed. |
@xinthink I'm using 0.12.0. Why am I still getting |
And the error is not even from my own code. It's from https://github.com/corymsmith/react-native-icons/blob/master/SMXIconImage.ios.js |
@facebook-github-bot answered |
Closing this issue as @jsierles says the question asked has been answered. Please help us by asking questions on StackOverflow. StackOverflow is amazing for Q&A: it has a reputation system, voting, the ability to mark a question as answered. Because of the reputation system it is likely the community will see and answer your question there. This also helps us use the GitHub bug tracker for bugs only. |
proccessColor will be pull out from react-native. import { processColor } from 'react-native'; |
I just upgraded from
v0.11.0
tov0.12.0
;After the upgrade I started getting crashes with the following error:
@ide @brentvatne /cc
UPDATE
it seems
react-devtools
has 2 related issues:facebook/react-devtools#223
facebook/react-devtools#214
The text was updated successfully, but these errors were encountered: