Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State update of Parent (not Owner) does not render the children - 0.14 #3991

Closed
rrag opened this issue May 31, 2015 · 1 comment
Closed

State update of Parent (not Owner) does not render the children - 0.14 #3991

rrag opened this issue May 31, 2015 · 1 comment

Comments

@rrag
Copy link

rrag commented May 31, 2015

say

var Owner = React.createClass({
  render: function () {
    return <Parent><Child foo="bar"/></Parent>
})

When Owner state is updated, the render function is called on Owner, Parent and Child.
When Parent state is updated, the render function of Parent is called, but not on the Child.

This was the expected behavior till 0.13.x, but with #2112 introduced a behavior where Parent state update can change the return of getChildContext and hence the Child needs an update.

jsbin explaining the problem.

Owner state update, renders both Parent and Child
Parent state update renders only the Parent

@rrag rrag changed the title State update of Parent (not Owner) does not render the children State update of Parent (not Owner) does not render the children - 0.14 May 31, 2015
@sophiebits
Copy link
Collaborator

See #2517.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants