Skip to content
This repository has been archived by the owner on Sep 28, 2022. It is now read-only.

Consider interning strings #48

Open
sunshowers opened this issue Dec 19, 2019 · 0 comments
Open

Consider interning strings #48

sunshowers opened this issue Dec 19, 2019 · 0 comments
Labels

Comments

@sunshowers
Copy link
Contributor

At the moment, we do several clones of strings for package IDs, feature IDs, etc. This isn't great, and ideally a graph would carry with it a pool of strings + internal references to them instead.

I've done some initial exploratory work at https://github.com/sunshowers/cargo-guppy/tree/string-interning, converting over PackageMetadata to have a lifetime parameter.

Related to #37 since interning package IDs will mean returning a custom PackageId<'g> instead of &'g PackageId.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant