From e44a45771861b86ef9c59ebca81156f9f224b116 Mon Sep 17 00:00:00 2001 From: Nick Gerleman Date: Wed, 8 Nov 2023 21:43:44 -0800 Subject: [PATCH 1/2] Fix OSS Build (#92) Summary: Pull Request resolved: https://github.com/facebookincubator/fbjni/pull/92 Differential Revision: D51146182 --- cxx/fbjni/detail/utf8.h | 1 + 1 file changed, 1 insertion(+) diff --git a/cxx/fbjni/detail/utf8.h b/cxx/fbjni/detail/utf8.h index 52e7984..1b606c2 100644 --- a/cxx/fbjni/detail/utf8.h +++ b/cxx/fbjni/detail/utf8.h @@ -16,6 +16,7 @@ #pragma once +#include #include #include From 13008148161188e08aa43eaefabe09e0af253c1b Mon Sep 17 00:00:00 2001 From: Nick Gerleman Date: Wed, 8 Nov 2023 21:43:44 -0800 Subject: [PATCH 2/2] Bump Gradle minSdkVersion (#91) Summary: https://github.com/facebookincubator/fbjni/commit/bd94aae8f47ffa012783b94bf53379f0db84f725 bumped to NDK 26 (latest LTS NDK). NDK 26 [dropped](https://github.com/android/ndk/wiki/Changelog-r26) [support](https://github.com/android/ndk/issues/1751) for KitKat, and NDK 25 already required minSDK 19, so our minSdk of 15 is too low. This bumps the minSdk, so that when we publish AARs for next fbjni published version, it errors if user is on earlier SDK. Differential Revision: D51146044 --- build.gradle | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build.gradle b/build.gradle index 8790b6b..5ca8673 100644 --- a/build.gradle +++ b/build.gradle @@ -36,7 +36,7 @@ android { } defaultConfig { - minSdkVersion 15 + minSdkVersion 21 targetSdkVersion 34 buildConfigField "boolean", "IS_INTERNAL_BUILD", 'true' namespace "com.facebook.fbjni"