Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react version in mephisto-task #991

Closed
jayhuynh opened this issue Jan 17, 2023 · 3 comments · Fixed by #905
Closed

Update react version in mephisto-task #991

jayhuynh opened this issue Jan 17, 2023 · 3 comments · Fixed by #905

Comments

@jayhuynh
Copy link

jayhuynh commented Jan 17, 2023

Hi @JackUrb , hope you are doing well.

I'm trying to run a custom react task with Mephisto which is using https://github.com/react-dnd/react-dnd/ as a depency for drag and drop feature. That package requires React version ^16.14.0. However, mephisto-task package is fixed with React 16.13.1 and I had react version conflict when I try to npm install react-dnd.

Therefore, I just wonder can we update mephisto-task package to accept newer react versions? I'm afraid that in the future we will use other packages that require latest react versions as well. Happy to hear if we have any alternative approaches 😄.

@JackUrb
Copy link
Contributor

JackUrb commented Jan 20, 2023

cc @pringshia about #899 and #905 and ongoing efforts to make mephisto-task future-react permissive

@pringshia
Copy link
Contributor

Hi @jayhuynh, I'm currently off the grid through next week. I can take a look at this when I return. In the meanwhile you may want to try to manually edit the package.json for mephisto-task to a higher react version and then upgrade it for your project as well. This strategy won't persist and you will need to redo it if you ever refresh your node_modules folder, but I think it may get you unblocked until I return.

@jayhuynh
Copy link
Author

Thank both of you. I'll follow that way @pringshia.

@pringshia pringshia linked a pull request Jan 27, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants