Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

BlenderBot2 search_queries not flushed. #4145

Closed
jxmsML opened this issue Nov 5, 2021 · 3 comments · Fixed by #4198
Closed

BlenderBot2 search_queries not flushed. #4145

jxmsML opened this issue Nov 5, 2021 · 3 comments · Fixed by #4198
Assignees
Labels

Comments

@jxmsML
Copy link
Contributor

jxmsML commented Nov 5, 2021

Bug description
Whenever hasattr(self.model_api.retriever, 'search_queries') is True, the 'search_queries' field will be included in model act.
However, hasattr(self.model_api.retriever, 'search_queries') is always True once the model searched in previous turns in the same episode (even if in the current turn, the model chooses to retrieve from memory not search thus no search is performed)

Reproduction steps

parlai i -mf zoo:blenderbot2/blenderbot2_400M/model --search-server XXX  --knowledge-access-method classify --query-generator-model-file zoo:sea/bart_sq_gen/model --loglevel debug

Expected behavior
If no search is performed when generating the model response in some turn, no search_queries and top_docs fields should be set in the model act

Logs
Please paste the command line output:

Output goes here

Additional context
Add any other context about the problem here. (like proxy settings, network setup, overall goals, etc.)

@jxmsML jxmsML self-assigned this Nov 8, 2021
@github-actions
Copy link

github-actions bot commented Dec 9, 2021

This issue has not had activity in 30 days. Please feel free to reopen if you have more issues. You may apply the "never-stale" tag to prevent this from happening.

@github-actions github-actions bot added the stale label Dec 9, 2021
@mojtaba-komeili
Copy link
Contributor

Any update on this? I think this is what I noticed in the chatbot too.

@jxmsML
Copy link
Contributor Author

jxmsML commented Dec 9, 2021

I've merged the pr #4198

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
2 participants