Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reexport Faiss version in c_api #1720

Closed
ava57r opened this issue Mar 1, 2021 · 5 comments
Closed

Reexport Faiss version in c_api #1720

ava57r opened this issue Mar 1, 2021 · 5 comments

Comments

@ava57r
Copy link
Contributor

ava57r commented Mar 1, 2021

Summary

Hello.

Library supports version defines here
https://github.com/facebookresearch/faiss/blob/master/faiss/Index.h#L19

I think this functionality will be useful in c_api.

@Enet4
Copy link
Contributor

Enet4 commented Mar 1, 2021

For additional context, this has been brought up at faiss-rs here, as a potential aid at determining whether some feature can be used by the given bindings.

I tried to understand how Python exports the version of Faiss. I suspect that all it does is hard-code the version from the header file via SWIG.
We could also copy those symbol declarations into one of the headers of the C API through some means, but maybe there is interest in embedding the version into the implementation objects instead (.a / .so). This would allow bindings to provide support for a range of versions, although currently this poses some risks due to versions not being semver compliant.

For the time being, it would be an improvement for users of the C API to have access to the same symbol definitions.

@mdouze mdouze added the install label Mar 1, 2021
@mdouze
Copy link
Contributor

mdouze commented Mar 1, 2021

Right, we should think about this.

@mdouze
Copy link
Contributor

mdouze commented May 31, 2023

Right, let's make an API entry to return the version (in the same fashion as get_compile_options() )

@junjieqi
Copy link
Contributor

#3688

now the version is supported from C_API

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants