Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MutableTimeseries shadowed by MutableScatterXY #597

Merged

Conversation

simchanu29
Copy link
Contributor

I noticed on the last commit of the main branch I weren't able to use MutableTimeseries. It seemed after some investigations it was always overshadowed by MutableScatterXY.

Way to reproduce the bug :

  1. Use Reactive Function Editor
  2. Create a new MutableTimeseries
  3. The created timeserie is a scatter plot.

I guessed it was because new_usertype in sol overwrite last type if a previous type with a different name but same base class has already been declared. So I used inheritance to declare two subtypes CreatedSeriesTime and CreatedSeriesXY deriving from CreatedSeriesBase.

Side note I also added lua math that I think was missing.

@facontidavide facontidavide merged commit e27f2b0 into facontidavide:main Feb 4, 2022
@facontidavide
Copy link
Owner

thanks a lot. I should release this fix soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants