Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When clamping a long variable-length array I found that the
jump
on the string deserialization wasn't working properly. I don't fully understand what was happening, but here are the rough conditions:string<=1 var_name
in the ros2 msg definition). I have no idea if that is related or not.I don't know if this is the correct fix or not. The proposal seems to mirror the decoding code directly below it.
If needed, I could probably create a minimal bagfile that recreates the issue.