-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does the VSCode tasks still work? #36
Comments
It looks like the error is saying that you need to install .net core 2.0 |
Sure. But as mentioned we can't use .NET Core 2.0. All projects in our solution is running .NET 6. |
@mwkcoding Am I misunderstanding something here, it seems you're using a different package? Regardless, a PR for this here should be relatively simple too as it should compile just fine with .NET6/8. |
@bakerhillpins I'm using the package linked in the wiki that is being linked to from this repo. I'm aware that the wiki being linked to is the one made by the original author. If there's a different package I should use, I'd like to know which one that would be. I also mentioned that I am aware that it's the original authors package I'm using in my last comment. |
It's the correct package, I never use the Task Runner, so I'm not too familiar with the code, but it looks like the issue is from the BundlerMinifier\src\BundlerMinifier\build\BuildBundlerMinifier2022.targets file; it uses the netstandard2.0 build when running in .net core; I just merged a PR from another user that adds net6.0 and net8.0 to the project, so I could take a look and see if I can modify it to use those builds for the tasks. I can try to get it into the next release if you don't mind helping to test the functionality before I release it' I'm going away in 20 days and would hate to leave the community with no support on a new version in case I miss anything in testing. |
Ok, I'll take your word for it but it's clearly throwing an error from a different NuGet package based upon the directory listed in the error: This repository doesn't even publish that package as far as I can tell, that's published by the original author's repository. This repo simply builds the @mwkcoding
When this package is published you could try installing it as a dotnet tool. #35 |
This is the library that I publish to nuget when I release new versions of the vsix https://www.nuget.org/packages/BuildBundlerMinifier2022 I could look into publishing BundlerMinifier.Core to nuget in the future, but I would probably have to rename it to do upload it; I'll have to see how much refactoring and testing that would require. |
It would be the core one I'd need. That's the CLI tool that allows it to be used in vscode tasks. According to the original author. |
@mwkcoding Would @bakerhillpins suggestion work for you in the short term if I can get the release out this week? @bakerhillpins You're right, I wasn't aware of BundlerMinifier.Core being a nuget package; I'll look into adding that to a future release. |
@failwyn Since we're getting close to a deadline, I ended up having to make another solution. I wrote Gulp tasks to replace the extension. However, I'm up for helping getting this to work for others. |
Sorry I couldn't get it fixed for you sooner, it's tough to find time with the kids home and traveling. |
That's completely understandable. Family time is important 🙏 |
This should work in the latest release. |
I tried installing this as a dotnet tool. It does not seem to work. I think we'll need the core package published. |
I just installed and ran it. Works fine for me. What errors are you receiving? |
@bakerhillpins Oh. I tried adding it to <ItemGroup>
<DotNetCliToolReference Include="BuildBundlerMinifier2022" Version="2.9.11" />
</ItemGroup> But adding it like |
Hrm.. have not seen that way to add a dotnet tool. You shouldn't need to manually add a reference to your project either. If you right click on the bundleconfig.json file and select |
@mwkcoding Ah, that's why I don't recognize it, that feature was deprecated a long time ago. dotnet/sdk#3115 |
I suppose our setup has been a bit wonky since the project was migrated from .NET Framework to .NET. Either way. It works by running the command! I'll close the issue. Thanks for the help @failwyn @bakerhillpins |
Installed product versions
Description
I'd like to use the Visual Studio Code tasks as defined in the wiki. However, it seems to be requiring .NET Core 2.0 Runtime which is way past EOL and not cross-platform. Can this be upgraded? Our use-case is that front-end developers would like to not have to open Visual Studio to bundle our JS files and I'm working towards fixing that. It'd be nice if we can keep using this extension as it would be the least invasive DX improvement.
Steps to recreate
Current behavior
Currently the task fails with the following output:

Expected behavior
The task should run without issues and not require Visual Studio to be present or open.
The text was updated successfully, but these errors were encountered: