From c9caafc045a20763b29b7312ad9cef9643c8cfa3 Mon Sep 17 00:00:00 2001 From: Matt Mayer Date: Thu, 1 Dec 2022 16:41:20 +0700 Subject: [PATCH] fix: comment fixes --- src/modules/internet/char-mappings.ts | 2 +- src/modules/internet/index.ts | 14 ++++++-------- 2 files changed, 7 insertions(+), 9 deletions(-) diff --git a/src/modules/internet/char-mappings.ts b/src/modules/internet/char-mappings.ts index 4d635e76eba..6b7843797ea 100644 --- a/src/modules/internet/char-mappings.ts +++ b/src/modules/internet/char-mappings.ts @@ -1,4 +1,4 @@ -// selectively sourced from https://github.com/sindresorhus/transliterate/blob/main/replacements.js (under MIT license) +// Selectively sourced from https://github.com/sindresorhus/transliterate/blob/08bbfd3a13ac393d945a430ed5ec62f044a08d70/replacements.js (under MIT license) const cyrillicMapping: { [key: string]: string } = Object.fromEntries([ ['А', 'A'], ['а', 'a'], diff --git a/src/modules/internet/index.ts b/src/modules/internet/index.ts index bdf0e6fdae1..dc3eaa624f7 100644 --- a/src/modules/internet/index.ts +++ b/src/modules/internet/index.ts @@ -160,29 +160,27 @@ export class InternetModule { break; } - //There may still be non-ascii characters in the result. - //First remove simple accents etc + // There may still be non-ascii characters in the result. + // First remove simple accents etc result = result .normalize('NFKD') //for example è decomposes to as e + ̀ .replace(/[\u0300-\u036f]/g, ''); // removes combining marks result = result .split('') - .map(function (char) { - //if we have a mapping for this character, (for Cyrillic, Greek etc) use it + .map((char) => { + // If we have a mapping for this character, (for Cyrillic, Greek etc) use it if (charMapping[char]) { return charMapping[char]; } if (char.charCodeAt(0) < 0x80) { - //keep ascii characters + // Keep ASCII characters return char; } - //final fallback return the Unicode char code value for Chinese, Japanese, Korean etc, base-36 encoded + // Final fallback return the Unicode char code value for Chinese, Japanese, Korean etc, base-36 encoded return char.charCodeAt(0).toString(36); }) .join(''); - - //remove spaces and ' result = result.toString().replace(/'/g, ''); result = result.replace(/ /g, '');