Localize format patterns for company.name

[ST-DDT]

Clear and concise description of the problem

faker/src/modules/company/index.ts

Lines 37 to 41 in fbddaa3

	const formats = [
	'{{name.lastName}} {{company.companySuffix}}',
	'{{name.lastName}} - {{name.lastName}}',
	'{{name.lastName}}, {{name.lastName}} and {{name.lastName}}',
	];

Currently the patterns are hardcoded to match English company names.

Suggested solution

The patterns should be localized so other locales can define custom patterns.

Alternative

No response

Additional context

There seems to be patterns/files for that already, but these needs to be checked/defined and referenced:

faker/src/locales/en/company/name.ts

Lines 1 to 5 in fbddaa3

	export default [
	'{{name.last_name}} {{company.suffix}}',
	'{{name.last_name}}-{{name.last_name}}',
	'{{name.last_name}}, {{name.last_name}} and {{name.last_name}}',
	];

but there is nothing for that in:

faker/src/definitions/company.ts

Line 6 in fbddaa3

export type CompanyDefinitions = LocaleEntry<{

There are also other PRs that work on the method so this should only be done after both:

• refactor(company): rename companyName to name #1166
• Deprecate company.name index parameter #1178

[ST-DDT]

@Shinigami92 Do you consider this a breaking change?

[Minozzzi]

Hello guys. I woud like contribute with this task.Can you guys assign to me?

[ST-DDT]

There is #1216 already.

[Shinigami92]

There is #1216 already.

But it looks like that it is for the name module but this issue is about company.name 🤔 is it?

[ST-DDT]

Oh yeah, you are right.

@Minozzzi I assigned you, because you asked first. If you are not longer interested please leave a comment.

[Minozzzi]

Alright @ST-DDT . I will try to contribute as best I can to this issue. 😀