You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I just migrated from faker and we use internet.domainWord to fake out customer subdomains in tests. After the migration, tests are intermittently failing because we get subdomains with the word jalapeño in them, which are not valid.
The simplest fix would be to remove jalapeño from the locale file here. With a quick scan, I don't see that there are other words with non-ascii characters in them. I would be happy to provide a PR, but I'm not sure of the implications of removing things from that file / whether changing the domainWordimplementation would be preferred.
We have a workaround, so not a big deal, but wanted to file while it is top of mind
Pre-Checks
Describe the bug
I just migrated from
faker
and we useinternet.domainWord
to fake out customer subdomains in tests. After the migration, tests are intermittently failing because we get subdomains with the wordjalapeño
in them, which are not valid.The simplest fix would be to remove
jalapeño
from the locale file here. With a quick scan, I don't see that there are other words with non-ascii characters in them. I would be happy to provide a PR, but I'm not sure of the implications of removing things from that file / whether changing thedomainWord
implementation would be preferred.We have a workaround, so not a big deal, but wanted to file while it is top of mind
Minimal reproduction code
faker.domainWord()
Additional Context
No response
Environment Info
Which module system do you use?
Used Package Manager
yarn
The text was updated successfully, but these errors were encountered: