Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

domainWord returns jalapeño #1538

Closed
9 of 10 tasks
pvatterott opened this issue Nov 7, 2022 · 1 comment
Closed
9 of 10 tasks

domainWord returns jalapeño #1538

pvatterott opened this issue Nov 7, 2022 · 1 comment
Labels
c: bug Something isn't working

Comments

@pvatterott
Copy link

Pre-Checks

Describe the bug

I just migrated from faker and we use internet.domainWord to fake out customer subdomains in tests. After the migration, tests are intermittently failing because we get subdomains with the word jalapeño in them, which are not valid.

The simplest fix would be to remove jalapeño from the locale file here. With a quick scan, I don't see that there are other words with non-ascii characters in them. I would be happy to provide a PR, but I'm not sure of the implications of removing things from that file / whether changing the domainWord implementation would be preferred.

We have a workaround, so not a big deal, but wanted to file while it is top of mind

Minimal reproduction code

faker.domainWord()

Additional Context

No response

Environment Info

System:
    OS: macOS 12.6
    CPU: (10) x64 Apple M1 Pro
    Memory: 20.50 MB / 16.00 GB
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 14.18.2 - /usr/local/bin/node
    Yarn: 1.22.19 - ~/.yarn/bin/yarn
    npm: 6.14.15 - /usr/local/bin/npm
  Browsers:
    Firefox: 106.0.5
    Safari: 16.0
  npmPackages:
    @faker-js/faker: 7.6.0 => 7.6.0

Which module system do you use?

  • CJS
  • ESM

Used Package Manager

yarn

@pvatterott pvatterott added c: bug Something isn't working s: pending triage Pending Triage labels Nov 7, 2022
@ST-DDT
Copy link
Member

ST-DDT commented Nov 7, 2022

Thanks for bringing this to our attention.
We already have an issue that we use to keep track of this issue.

Duplicate of #1105 (#1520)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants