Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add api docs diff to the PR #1754

Closed
ST-DDT opened this issue Jan 18, 2023 · 3 comments · Fixed by #1755
Closed

Add api docs diff to the PR #1754

ST-DDT opened this issue Jan 18, 2023 · 3 comments · Fixed by #1755
Assignees
Labels
c: docs Improvements or additions to documentation c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug s: on hold Blocked by something or frozen to avoid conflicts
Milestone

Comments

@ST-DDT
Copy link
Member

ST-DDT commented Jan 18, 2023

Clear and concise description of the problem

Currently it is hard to review where in the api-docs a change takes place.

Suggested solution

Add a CI step posting a list of changed modules/methods (in the api-docs).

MVP: A simple list

Ideas for extensions:

Alternative

Commit all generated docs to git.

Additional context

This idea came up again in #1752 (comment)
I remember discussing this somewhere before, but couldn't find an open issue related to it.

@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: pending triage Pending Triage s: accepted Accepted feature / Confirmed bug c: infra Changes to our infrastructure or project setup labels Jan 18, 2023
@ST-DDT
Copy link
Member Author

ST-DDT commented Jan 18, 2023

Commit all generated docs to git.

These files are very long and ugly, so they are potentially hard to review:

Review Preview

Currently

grafik

Prettified

grafik

So IMO it is best to just list where to look (and maybe what to look for).

@ST-DDT ST-DDT moved this to Todo in Faker Roadmap Jan 18, 2023
@ST-DDT ST-DDT removed the s: pending triage Pending Triage label Jan 18, 2023
@ST-DDT ST-DDT self-assigned this Jan 18, 2023
@ST-DDT
Copy link
Member Author

ST-DDT commented Jan 18, 2023

I created a first script to create checksums and compare diffs:

https://next--serene-sprite-f3ef50.netlify.app/api-diff-index.json

Unfortunately, there is always a diff in:

{
  Date: [ 'between', 'betweens', 'future', 'past', 'recent', 'soon' ],
  Git: [ 'commitDate' ]
}

Due to the missing refDate in the docs generation.

Blocked by #859

@ST-DDT ST-DDT added the s: on hold Blocked by something or frozen to avoid conflicts label Jan 18, 2023
@ST-DDT ST-DDT moved this from Todo to In Progress in Faker Roadmap Jan 18, 2023
@ST-DDT
Copy link
Member Author

ST-DDT commented Jan 18, 2023

Why do I keep finding new issues? 😢

@github-project-automation github-project-automation bot moved this from In Progress to Done in Faker Roadmap Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug s: on hold Blocked by something or frozen to avoid conflicts
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant