Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some urlPicsumPhotos are broken #1964

Closed
matthewmayer opened this issue Mar 23, 2023 · 2 comments · Fixed by #1968
Closed

some urlPicsumPhotos are broken #1964

matthewmayer opened this issue Mar 23, 2023 · 2 comments · Fixed by #1968
Assignees
@matthewmayer @Shinigami92
Labels
c: bug Something isn't working m: image Something is referring to the image module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Milestone
v8.x

Comments

@matthewmayer
Copy link
Contributor

example https://picsum.photos/id/725/640/480

Unfortunately picsum.photos appears to have some gaps in the 1...1000 range

See DMarby/picsum-photos#83

We could blacklist the missing images?
@matthewmayer matthewmayer added c: bug Something isn't working p: 1-normal Nothing urgent s: needs decision Needs team/maintainer decision m: image Something is referring to the image module labels Mar 23, 2023
@matthewmayer matthewmayer self-assigned this Mar 23, 2023
@matthewmayer
Copy link
Contributor Author

Better idea

We can use https://picsum.photos/seed/SOMEVALUE/w/h instead then we don't need to worry about missing ids

@ST-DDT ST-DDT moved this to Todo in Faker Roadmap Mar 23, 2023
@ST-DDT ST-DDT added s: accepted Accepted feature / Confirmed bug and removed s: needs decision Needs team/maintainer decision labels Mar 23, 2023
@ST-DDT
Copy link
Member

ST-DDT commented Mar 23, 2023

Lets do that.

@Shinigami92 Shinigami92 mentioned this issue Mar 23, 2023
Merged
@Shinigami92 Shinigami92 moved this from Todo to Awaiting Review in Faker Roadmap Mar 23, 2023
@Shinigami92 Shinigami92 self-assigned this Mar 23, 2023
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Faker Roadmap Mar 30, 2023
@ST-DDT ST-DDT mentioned this issue Sep 22, 2024
Closed
@xDivisionByZerox xDivisionByZerox mentioned this issue Jan 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthewmayer matthewmayer

@Shinigami92 Shinigami92

Labels
c: bug Something isn't working m: image Something is referring to the image module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging a pull request may close this issue.

fix(image): use seeded picsum faker-js/faker
3 participants
@matthewmayer @ST-DDT @Shinigami92