Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): fix faker v7 code example for locale migration #2125

Merged
merged 4 commits into from
May 6, 2023
Merged

fix(docs): fix faker v7 code example for locale migration #2125

merged 4 commits into from
May 6, 2023

Conversation

matthewmayer
Copy link
Contributor

fix #1905

@matthewmayer matthewmayer requested a review from a team May 4, 2023 14:17
@matthewmayer matthewmayer requested a review from a team as a code owner May 4, 2023 14:17
@matthewmayer matthewmayer self-assigned this May 4, 2023
@matthewmayer matthewmayer added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent c: locale Permutes locale definitions labels May 4, 2023
@codecov
Copy link

codecov bot commented May 4, 2023 •
edited
Loading

Codecov Report

Merging #2125 (ed638ea) into next (5336334) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head ed638ea differs from pull request most recent head d8ddefe. Consider uploading reports for the commit d8ddefe to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #2125   +/-   ##
=======================================
  Coverage   99.59%   99.60%           
=======================================
  Files        2605     2605           
  Lines      244951   244951           
  Branches     1255     1254    -1     
=======================================
+ Hits       243970   243973    +3     
+ Misses        954      951    -3     
  Partials       27       27

see 2 files with indirect coverage changes

ST-DDT
ST-DDT previously approved these changes May 4, 2023
View reviewed changes
@ST-DDT ST-DDT requested review from a team May 4, 2023 14:40
@matthewmayer @xDivisionByZerox
Update docs/guide/upgrading.md
bfefe64 
Co-authored-by: DivisionByZero <[email protected]>
@ST-DDT ST-DDT changed the title fix(docs): fix faker 7.x.x old code for locale migration fix(docs): fix faker v7 code example for locale migration May 6, 2023
@ST-DDT ST-DDT enabled auto-merge (squash) May 6, 2023 13:48
@ST-DDT ST-DDT merged commit b570461 into faker-js:next May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xDivisionByZerox xDivisionByZerox xDivisionByZerox left review comments

@ST-DDT ST-DDT ST-DDT approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@ejcheng ejcheng ejcheng approved these changes

Assignees

@matthewmayer matthewmayer

Labels
c: docs Improvements or additions to documentation c: locale Permutes locale definitions p: 1-normal Nothing urgent
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.0 - Module Re-Shuffling
Development

Successfully merging this pull request may close these issues.

Further improvements to migration guide for switching locales
5 participants
@matthewmayer @ST-DDT @Shinigami92 @ejcheng @xDivisionByZerox