Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Yoruba Language (yo_NG) as a new locale #2341

Closed
mrsimi opened this issue Aug 25, 2023 · 3 comments · Fixed by #2363
Closed

Add the Yoruba Language (yo_NG) as a new locale #2341

mrsimi opened this issue Aug 25, 2023 · 3 comments · Fixed by #2363
Assignees
Labels
c: feature Request for new feature c: locale Permutes locale definitions p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Milestone

Comments

@mrsimi
Copy link
Contributor

mrsimi commented Aug 25, 2023

Clear and concise description of the problem

As a developer using faker I want to be able to generate fake data that are native to the Yoruba Language. This will include person names, dates, and color.

I will be willing to create a PR for it.

Suggested solution

Create a locale feature that is for the yoruba language under the yo_NG ISO

Alternative

No response

Additional context

No response

@mrsimi mrsimi added c: feature Request for new feature s: pending triage Pending Triage s: waiting for user interest Waiting for more users interested in this feature labels Aug 25, 2023
@github-actions
Copy link
Contributor

Thank you for your feature proposal.

We marked it as "waiting for user interest" for now to gather some feedback from our community:

  • If you would like to see this feature be implemented, please react to the description with an up-vote (:+1:).
  • If you have a suggestion or want to point out some special cases that need to be considered, please leave a comment, so we are aware about them.

We would also like to hear about other community members' use cases for the feature to give us a better understanding of their potential implicit or explicit requirements.

We will start the implementation based on:

  • the number of votes (:+1:) and comments
  • the relevance for the ecosystem
  • availability of alternatives and workarounds
  • and the complexity of the requested feature

We do this because:

  • There are plenty of languages/countries out there and we would like to ensure that every method can cover all or almost all of them.
  • Every feature we add to faker has "costs" associated to it:
    • initial costs: design, implementation, reviews, documentation
    • running costs: awareness of the feature itself, more complex module structure, increased bundle size, more work during refactors

View more issues which are waiting for user interest

@matthewmayer
Copy link
Contributor

Are new locales expected to hit the 10 👍 threshold like feature requests? Because other recent locale additions have not had to (Serbian, Danish, Esperanto etc). My feeling is if someone is willing to put in the work to do the PR and its verifiable (e.g. not so obscure a language that it doesn't appear on Google Translate) then it shouldnt have to hit a 10 vote minimum to be merged.

@ST-DDT
Copy link
Member

ST-DDT commented Aug 26, 2023

FFR: yo_NG the language used in Nigeria.


Feel free to create the PR. But ~one PR per module/category please e.g. person, location. (Metadata doesn't count as module/category.)
Small sequential PRs are easier to review for us then large or parallel ones.

Thanks for your help.

@ST-DDT ST-DDT added p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug c: locale Permutes locale definitions and removed s: pending triage Pending Triage s: waiting for user interest Waiting for more users interested in this feature labels Aug 26, 2023
@matthewmayer matthewmayer linked a pull request Sep 1, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: feature Request for new feature c: locale Permutes locale definitions p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants