From dcd8e72269a4e2660a7848ec8d9518375218aa1e Mon Sep 17 00:00:00 2001 From: ST-DDT Date: Sun, 14 Jan 2024 13:49:00 +0100 Subject: [PATCH 1/2] refactor(internet): deprecated redundant avatar method --- src/modules/internet/index.ts | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/src/modules/internet/index.ts b/src/modules/internet/index.ts index 395266fb588..c67bb8567b1 100644 --- a/src/modules/internet/index.ts +++ b/src/modules/internet/index.ts @@ -41,16 +41,26 @@ export class InternetModule extends ModuleBase { /** * Returns a random avatar url. * + * @see faker.image.avatarLegacy(): For the replacement method. + * @see faker.image.avatar(): For the replacement method with a wider variety of avatars. + * * @example * faker.internet.avatar() * // 'https://cloudflare-ipfs.com/ipfs/Qmd3W5DuhgHirLHGVixi6V76LhCkZUz6pnFt5AJBiyvHye/avatar/315.jpg' * * @since 2.0.1 + * + * @deprecated Use `faker.image.avatar()` instead. */ avatar(): string { - return `https://cloudflare-ipfs.com/ipfs/Qmd3W5DuhgHirLHGVixi6V76LhCkZUz6pnFt5AJBiyvHye/avatar/${this.faker.number.int( - 1249 - )}.jpg`; + deprecated({ + deprecated: 'faker.internet.avatar()', + proposed: 'faker.image.avatarLegacy() or faker.image.avatar()', + since: '8.4', + until: '9.0', + }); + // TODO @ST-DDT 2024-01-14: Replace with `faker.image.avatar()` in v9 + return this.faker.image.avatarLegacy(); } /** From 248d2f371e917b3b857138dad81cbd22dde4c923 Mon Sep 17 00:00:00 2001 From: ST-DDT Date: Sun, 14 Jan 2024 13:52:00 +0100 Subject: [PATCH 2/2] Update src/modules/internet/index.ts --- src/modules/internet/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/internet/index.ts b/src/modules/internet/index.ts index c67bb8567b1..08ed60b6b4f 100644 --- a/src/modules/internet/index.ts +++ b/src/modules/internet/index.ts @@ -59,7 +59,7 @@ export class InternetModule extends ModuleBase { since: '8.4', until: '9.0', }); - // TODO @ST-DDT 2024-01-14: Replace with `faker.image.avatar()` in v9 + // TODO @ST-DDT 2024-01-14: Remove or replace with `faker.image.avatar()` in v9 return this.faker.image.avatarLegacy(); }