Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locales shouldn't be enforced #1323

Closed
olingern opened this issue Aug 1, 2018 · 1 comment · Fixed by #1368
Closed

Locales shouldn't be enforced #1323

olingern opened this issue Aug 1, 2018 · 1 comment · Fixed by #1368

Comments

@olingern
Copy link

olingern commented Aug 1, 2018

Issue

This LOC is causing our test suite to fail because of the fallback logic we have in place that specifically relies on locales not being enforced.

This gem shouldn't change environment settings that may affect test suites that rely on observing them in different states.

@shioyama
Copy link

shioyama commented Aug 6, 2018

Just to echo: I18n.enforce_available_locales is not something that a gem should be setting. It is a global that is intended to be configured based on the needs of the application.

Concretely: applications which use faker even only as a development dependency may be getting incorrect results from their specs because I18n.enforce_available_locales is true in dev mode but false in prod mode. This could potentially result in very misleading results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants