Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect length of Bank Account Number #1472

Closed
nomanurrehman opened this issue Nov 12, 2018 · 1 comment · Fixed by #1477
Closed

Incorrect length of Bank Account Number #1472

nomanurrehman opened this issue Nov 12, 2018 · 1 comment · Fixed by #1477

Comments

@nomanurrehman
Copy link

The method call Faker::Bank.account_number(15) returns an account number that is 14 digits long. Should it not be 15 digits long? Is this the intended behaviour?

I am happy to fix this and submit a pull request.

Thanks.
@gkunwar
Copy link
Contributor

gkunwar commented Nov 16, 2018

Great @nomanurrehman , Waiting your PR.

@jguthrie100 jguthrie100 mentioned this issue Nov 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed bank account length jguthrie100/faker
2 participants
@gkunwar @nomanurrehman