Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace deprecation is causing breaking changes #1576

Closed
petewalker opened this issue Mar 18, 2019 · 2 comments
Closed

Namespace deprecation is causing breaking changes #1576

petewalker opened this issue Mar 18, 2019 · 2 comments

Comments

@petewalker
Copy link

Describe the bug

Your method of deprecation whilst moving generators out into namespaces is causing breaking changes when using methods like unique

To Reproduce

name = Faker::Dog.unique.name
# NoMethodError:
#       undefined method `unique' for Faker::Dog:Class

Expected behavior

A deprecation notice is raised, no errors:

name = Faker::Dog.unique.name
# NOTE: Faker::Dog.unique.name is deprecated; use Faker::Creature::Dog.unique.name instead. It will be removed on or after 2019-01-01.

Additional context

Because you've moved these classes into modules, you're no longer inheriting from Base.

@vbrazo
Copy link
Member

vbrazo commented Jun 20, 2019

@petewalker we've just released a new version and this issue should disappear. Thanks for reporting this issue!

@vbrazo
Copy link
Member

vbrazo commented Jun 20, 2019

btw Faker::Dog.unique.name is now Faker::Creature::Dog.unique.name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants