Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faker is missing drones #2091

Closed
sudeeptarlekar opened this issue Jul 24, 2020 · 2 comments · Fixed by #2096
Closed

Faker is missing drones #2091

sudeeptarlekar opened this issue Jul 24, 2020 · 2 comments · Fixed by #2096

Comments

@sudeeptarlekar
Copy link
Contributor

sudeeptarlekar commented Jul 24, 2020

Currently faker is missing drone data, is it good idea to add drone models?

If you're adding new objects, please describe how you would use them
This can be used to generate fake drone models e.g.

Faker::Drone.model            #=> "DJI Mavic Air 2"

Additional context
Additionally we can add other attributes for drone like camera model, battery capacity etc.

Faker::Drone.camera_model        #=> "DJI Mavic 2 Zoom"
Faker::Drone.battery_capacity    #=> "3850 mAh"
Faker::Drone.battery_type        #=> "LiPo 4S"

Additionally I think instead of calling all these methods Faker::Drone.model should return object containing all drone properties.

model = Faker::Drone.model
model.name                    #=> "DJI Mavic Air 2"
model.battery_capacity        #=> "3850 mAh"
model.camera_model            #=> "DJI Mavic 2 Zoom"

Would like to hear thoughts from others, and then will raise PR if this sounds good

@psibi
Copy link
Member

psibi commented Jul 25, 2020

Sounds good to me.

@sudeeptarlekar
Copy link
Contributor Author

Cool then will add drones in faker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants