Company spanish_organisation_number invalid

[rjurado01]

Describe the bug

Some spanish company CIF generated are invalid. For example: N6043409

spanish_cif_control_digit is missing

To Reproduce

Faker::Company.spanish_organisation_number

Expected behavior

LETTERS_CIF = %w[A B C D E F G H J N P Q R S U V W]
LETTERS_CIF_NUMBER = %w[P Q S W]
LETTERS_CIF_CONTROL = %w[J A B C D E F G H I]
REGEX_CIF = /^(#{LETTERS_CIF.join('|')})\-?(\d{7})\-?(\d|#{LETTERS_CIF_CONTROL.join('|')})$/

`N6043409` =~ REGEX_CIF # invalid CIF generated by faker
=> nil

'U59881409' =~ REGEX_CIF # valid CIF generated by faker
=> 0

Additional context

Example of validation method:

def cif_valid?(cif)
  if cif =~ REGEX_CIF
    number = Regexp.last_match(2)
    first_letter = Regexp.last_match(1)
    province_code = number[0..1]
    actual_control = Regexp.last_match(3)

    total = number.split('').each_with_index.inject(0) do |acc, (element, index)|
      acc + if index.even?
              (element.to_i * 2).digits.inject(:+)
            else
              element.to_i
            end
    end

    decimal = total.digits.first
    expected_control = decimal != 0 ? 10 - decimal : decimal

    # Control code must be a letter
    return LETTERS_CIF_CONTROL[expected_control] if LETTERS_CIF_NUMBER.include?(first_letter) ||
                                                    province_code == '00'

    # Control code will be a number or a letter
    return [expected_control.to_s,
            LETTERS_CIF_CONTROL[expected_control]].include?(actual_control)
  end

  false
end

[laulujan]

Hello, is it ok if I give it a try on this issue?

[thdaraujo]

fixed by #2351