Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

locale "en-GB.yml" misses country_code (44) #2730

Closed
ghost opened this issue Mar 16, 2023 · 3 comments · Fixed by #2731
Closed

locale "en-GB.yml" misses country_code (44) #2730

ghost opened this issue Mar 16, 2023 · 3 comments · Fixed by #2731
Labels
🐞 Issue: Bug

Comments

@ghost
Copy link

ghost commented Mar 16, 2023

When using "en-GB" locale, the created country code (44) is not used, as missing in the yml file.

current

...
internet:
  domain_suffix: [co.uk, com, biz, info, name]
phone_number:
  formats: [...

expected

...
internet:
  domain_suffix: [co.uk, com, biz, info, name]
country_code: ['44']
phone_number:
  formats: ['...
@ghost ghost added the 🐞 Issue: Bug label Mar 16, 2023
@psibi
Copy link
Member

psibi commented Mar 16, 2023

Thanks for pointing it out, pull requests and a corresponding test welcome.

@jremes-foss jremes-foss mentioned this issue Mar 17, 2023
Merged
@jremes-foss
Copy link
Contributor

Hi @psibi and @PhiliGor. There is a pull request now fixing this issue. Thank you.

@psibi
Copy link
Member

psibi commented Mar 17, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐞 Issue: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add country code +44 to en-gb locale jremes-foss/faker-1
2 participants
@psibi @jremes-foss