diff --git a/CHANGELOG.md b/CHANGELOG.md index 4936798f89..d34ff4e919 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -52,6 +52,7 @@ - [PR #1117](https://github.com/stympy/faker/pull/1117) Added Ukrainian entries to yml [@RomanIsko](https://github.com/RomanIsko) ### Bug/Fixes +- [PR #1241](https://github.com/stympy/faker/pull/1241) Add missing tests reported by SimpleCov [@aamarill](https://github.com/aamarill) - [PR #1240](https://github.com/stympy/faker/pull/1240) Add some tests [@aamarill](https://github.com/aamarill) - [PR #1238](https://github.com/stympy/faker/pull/1238) pluralized file to match link name in the readme [@Connerh92](https://github.com/Connerh92) - [PR #1232](https://github.com/stympy/faker/pull/1232) Fix file permissions [@tagliala](https://github.com/tagliala) diff --git a/lib/faker/types.rb b/lib/faker/types.rb index b4c71d74a5..e548abaae1 100644 --- a/lib/faker/types.rb +++ b/lib/faker/types.rb @@ -53,8 +53,6 @@ def random_type rb_string when :fixnum rb_integer - else - rb_integer end end @@ -70,8 +68,6 @@ def random_complex_type rb_hash when :array rb_array - else - rb_integer end end diff --git a/test/test_faker_char.rb b/test/test_faker_char.rb new file mode 100644 index 0000000000..36b9601064 --- /dev/null +++ b/test/test_faker_char.rb @@ -0,0 +1,14 @@ +require File.expand_path(File.dirname(__FILE__) + '/test_helper.rb') + +class TestFakerChar < Test::Unit::TestCase + def setup + @tester = Faker::Char + end + + def test_fix_umlauts + assert @tester.fix_umlauts('ä') == 'ae' + assert @tester.fix_umlauts('ö') == 'oe' + assert @tester.fix_umlauts('ü') == 'ue' + assert @tester.fix_umlauts('ß') == 'ss' + end +end diff --git a/test/test_faker_unique_generator.rb b/test/test_faker_unique_generator.rb index ae1823712e..53ca80c6d4 100644 --- a/test/test_faker_unique_generator.rb +++ b/test/test_faker_unique_generator.rb @@ -8,6 +8,15 @@ def test_generates_unique_values assert_equal([1, 2], result.sort) end + def test_respond_to_missing + stubbed_generator = Object.new + + generator = Faker::UniqueGenerator.new(stubbed_generator, 3) + + assert_equal(generator.send(:respond_to_missing?, 'faker_address'), true) + assert_equal(generator.send(:respond_to_missing?, 'address'), false) + end + def test_returns_error_when_retries_exceeded stubbed_generator = Object.new def stubbed_generator.test diff --git a/test/test_helper.rb b/test/test_helper.rb index d9e8ddb88a..09b602057c 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -1,7 +1,7 @@ require 'simplecov' SimpleCov.formatter = SimpleCov::Formatter::HTMLFormatter SimpleCov.start do - add_filter ['.bundle', 'test'] + add_filter ['.bundle', 'test', 'lib/extensions'] end require 'test/unit' diff --git a/test/test_ru_locale.rb b/test/test_ru_locale.rb index fa4f54ae9d..2f79350124 100644 --- a/test/test_ru_locale.rb +++ b/test/test_ru_locale.rb @@ -36,6 +36,7 @@ def test_ru_methods assert Faker::Company.prefix.is_a? String assert Faker::Company.suffix.is_a? String assert Faker::Company.name.is_a? String + assert Faker::Char.romanize_cyrillic('').is_a? String end def test_ru_default_country diff --git a/test/test_uk_locale.rb b/test/test_uk_locale.rb index 1104554719..f25da34249 100644 --- a/test/test_uk_locale.rb +++ b/test/test_uk_locale.rb @@ -41,4 +41,8 @@ def test_uk_states_do_not_have_abbreviations def test_uk_company_prefix_returns_true_value assert_send([Faker::Company, :prefix]) end + + def test_uk_romanize_cyrillic + assert Faker::Char.romanize_cyrillic('').is_a? String + end end