From 9ea7a9c13ac1eaa7a679f2a283fa836c54653bd4 Mon Sep 17 00:00:00 2001
From: Kirk Wang <kirk.wang@scientist.com>
Date: Mon, 13 Nov 2023 14:23:25 -0800
Subject: [PATCH] Favor 'The Room' instead of 'Room'

This commit will rename instances of room to the_room including the
locales.  Originally the `room.md` had a typo that referenced ::Room and
not ::TheRoom which is also fixed here.

Ref:
  - https://github.com/faker-ruby/faker/issues/2787

Co-authored-by: Jamal-A-Mohamed <jamalashur@gmail.com>
Co-authored-by: Salvador <salvador.tena@scientist.com>
---
 doc/movies/room.md                                    | 11 -----------
 doc/movies/the_room.md                                | 11 +++++++++++
 lib/faker/movies/{room.rb => the_room.rb}             |  8 ++++----
 lib/locales/en/{room.yml => the_room.yml}             |  2 +-
 .../{test_faker_room.rb => test_faker_the_room.rb}    |  0
 5 files changed, 16 insertions(+), 16 deletions(-)
 delete mode 100644 doc/movies/room.md
 create mode 100644 doc/movies/the_room.md
 rename lib/faker/movies/{room.rb => the_room.rb} (89%)
 rename lib/locales/en/{room.yml => the_room.yml} (99%)
 rename test/faker/movies/{test_faker_room.rb => test_faker_the_room.rb} (100%)

diff --git a/doc/movies/room.md b/doc/movies/room.md
deleted file mode 100644
index 365e1beb15..0000000000
--- a/doc/movies/room.md
+++ /dev/null
@@ -1,11 +0,0 @@
-# Faker::Movies::Room
-
-```ruby
-Faker::Movies::Room.actor #=> "Tommy Wiseau"
-
-Faker::Movies::Room.character #=> "Johnny"
-
-Faker::Movies::Room.location #=> "Johnny's Apartment"
-
-Faker::Movies::Room.quote #=> "A-ha-ha-ha! What a story, Mark!"
-```
diff --git a/doc/movies/the_room.md b/doc/movies/the_room.md
new file mode 100644
index 0000000000..9892da5acc
--- /dev/null
+++ b/doc/movies/the_room.md
@@ -0,0 +1,11 @@
+# Faker::Movies::TheRoom
+
+```ruby
+Faker::Movies::TheRoom.actor #=> "Tommy Wiseau"
+
+Faker::Movies::TheRoom.character #=> "Johnny"
+
+Faker::Movies::TheRoom.location #=> "Johnny's Apartment"
+
+Faker::Movies::TheRoom.quote #=> "A-ha-ha-ha! What a story, Mark!"
+```
diff --git a/lib/faker/movies/room.rb b/lib/faker/movies/the_room.rb
similarity index 89%
rename from lib/faker/movies/room.rb
rename to lib/faker/movies/the_room.rb
index 6a0210bdc7..e2f22b522e 100644
--- a/lib/faker/movies/room.rb
+++ b/lib/faker/movies/the_room.rb
@@ -14,7 +14,7 @@ class << self
         #
         # @faker.version next
         def actor
-          fetch('room.actors')
+          fetch('the_room.actors')
         end
 
         ##
@@ -27,7 +27,7 @@ def actor
         #
         # @faker.version next
         def character
-          fetch('room.characters')
+          fetch('the_room.characters')
         end
 
         ##
@@ -40,7 +40,7 @@ def character
         #
         # @faker.version next
         def location
-          fetch('room.locations')
+          fetch('the_room.locations')
         end
 
         ##
@@ -55,7 +55,7 @@ def location
         #
         # @faker.version next
         def quote
-          fetch('room.quotes')
+          fetch('the_room.quotes')
         end
       end
     end
diff --git a/lib/locales/en/room.yml b/lib/locales/en/the_room.yml
similarity index 99%
rename from lib/locales/en/room.yml
rename to lib/locales/en/the_room.yml
index 3cd1b49a6e..7dd89bd5a5 100644
--- a/lib/locales/en/room.yml
+++ b/lib/locales/en/the_room.yml
@@ -1,6 +1,6 @@
 en:
   faker:
-    room:
+    the_room:
       actors:
         - Tommy Wiseau
         - Juliette Danielle
diff --git a/test/faker/movies/test_faker_room.rb b/test/faker/movies/test_faker_the_room.rb
similarity index 100%
rename from test/faker/movies/test_faker_room.rb
rename to test/faker/movies/test_faker_the_room.rb