Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FalcoSideKick Alertmanager include "description" annotation #477

Closed
msalman899 opened this issue May 9, 2023 · 5 comments
Closed

FalcoSideKick Alertmanager include "description" annotation #477

msalman899 opened this issue May 9, 2023 · 5 comments
Milestone

Comments

@msalman899
Copy link

Hello,

it would be convenient if we can add "description" annotation as well for falcosidekick alert manager forwarder.

@Issif
Copy link
Member

Issif commented May 9, 2023

Hi,

Can you elaborate what you call "description" please. If you refer to the description field in the rules, is only there for the humans to understand the rules and they are not part of the alerts from Falco.

@msalman899
Copy link
Author

Yes indeed, actually the way we have configured alert manager receivers on our side they primarily rely on "description" annotation so it would really help if we can add "description" annotation too.

@Issif
Copy link
Member

Issif commented May 9, 2023

You should rely on the tags/rule name/priority, there's no way for falcosidekick to add the description field in the alerts, it depends of falco itself

@msalman899
Copy link
Author

I think it should be simple by adding this line here

amPayload.Annotations["description"] = falcopayload.Output

@Issif
Copy link
Member

Issif commented May 10, 2023

OK I see what you mean now. I'll create a PR to add this annotation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants