Fix multi-level path deps #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the top-level app has a path-based dependency (A), and that dependency also has a path-based dependency (B) exsync would fail to start because it tried to use the relative path from dependency B from its own working directory which failed because the path to B is relative to A's directory. So this commit uses `Path.expand/2` to get the correct path to the dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the top-level app has a path-based dependency (A), and that dependency also has a path-based dependency (B) exsync would fail to start because it tried to use the relative path from dependency B from its own working directory which failed because the path to B is relative to A's directory.
So this commit uses
Path.expand/2to get the correct path to the dependency.